Add Seed43 Extension#3370
Conversation
Added the Seed43 tool to extensions.
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary:
This PR adds the Seed43 community extension entry to extensions/extensions.json, making the extension discoverable by pyRevit. The entry includes the standard metadata fields: name, description, author, URL, website, and dependency list.
Review Summary:
The change is minimal — a single JSON object appended to the extensions array. Two issues were found: the closing brace of the new entry is under-indented (4 spaces instead of 8), breaking alignment with every other entry in the file; and both boolean fields (builtin, rocket_mode_compatible) use native JSON false values rather than the string "False" convention used throughout the rest of the file, which may cause unexpected behavior depending on how pyRevit parses these fields.
Suggestions
| "website": "https://seed43.org", | ||
| "image": "", | ||
| "dependencies": [] | ||
| } |
There was a problem hiding this comment.
The closing brace of the new entry is not indented correctly — it uses 4 spaces instead of 8, breaking the structural alignment with every other entry in the file. This is valid JSON (parsers don't care), but it's inconsistent with the entire rest of the file and violates the Black formatting / 4-space indentation convention enforced by the repo.
| } | |
| } |
actions
Feedback: Rate this comment to help me improve future code reviews:
- 👍 Good - Helpful and accurate
- 👎 Poor - Wrong, unclear, or unhelpful
- Skip if you don't have any strong opinions either way.
| }, | ||
| { | ||
| "builtin": false, | ||
| "rocket_mode_compatible": false, |
There was a problem hiding this comment.
The new entry uses native JSON booleans (false) for builtin and rocket_mode_compatible, while every other entry in the file uses string booleans ("False" / "True"). This inconsistency may cause parsing issues depending on how pyRevit reads these fields.
Please align with the existing convention:
"builtin": "False",
"rocket_mode_compatible": "False",actions
Feedback: Rate this comment to help me improve future code reviews:
- 👍 Good - Helpful and accurate
- 👎 Poor - Wrong, unclear, or unhelpful
- Skip if you don't have any strong opinions either way.
Fix Seed43 entry: string booleans, indentation, and improved description
|
Some feedback if you're ok with that. I have not tested any features, just opened up on single button:
|
|
Thank you for your advice. I will look into utilising the pyRevit scripts snippets. I have always just copy and pasted sections as needed I’m still learning as I go. noted: I will look at extracting the metadata into yamel files no issues it was easy for me to do it that way cos of habit, time for a new habit. I have quite a bit of work still to do on evening but Rome wasn’t built in a day ;) I did originally have light and dark icons but I disused to go generic one for both modes. I do have a script that runs on Revit startup, that checks the version on git and user’s system for my tools and serves a pop up if they have an update. I hope this is not any violation of pyRevit policy? |
|
pyrevit has a built-in visual indicator here if an update to any extension is available. I'm not sure if that still works, or got broken during some update, would be good to test it again. I wouldn't know of any violation to do it like you describing though, may just be annoying to click away |
Seed43 Image link added to extensions.json
2 participants
Add Seed43 Extension to extensions.json (for newer pyRevit builds)
Description
This extension is designed for newer builds of pyRevit and provides a set of productivity tools for Revit, including:
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
Thank you for contributing to pyRevit! 🎉